View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0009005Legion CoreOther bugs / Остальноеpublic2020-03-06 01:272020-11-16 13:27
ReporterSulphosAssigned ToSun of a Bit 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionreopened 
Summary0009005: Combat log: SPELL_PERIODIC_DAMAGE broken (negative damage on warcraftlogs.com)
DescriptionWhen I upload a log (with advanced combat logging enabled) to warcraftlogs.com, the damage meter is broken. Dot classes end up with negative damage.

See screenshot 1 "warcraftlogs broken damage meter".
See example log: https://www.warcraftlogs.com/reports/Rh6mgax3nDXCHwpQ#fight=last

Screenshot 2 shows my combat log, filtered by my Agony SPELL_PERIODIC_DAMAGE damage of an Imonar fight. You can see that the 26th column (before the "32") is a high number. It starts with 1738507162 and increments up to 2135185101. Afterwards it's 0 in every line.

...,1738507162,32,0,0,0,nil,nil,nil
...
.... [number increments]
...
...,2135185101,32,0,0,0,1,nil,nil
...,0,32,0,0,0,nil,nil,nil
....
.... [number stays 0 till end of fight]

When I change this high number before the "32" to 0 or -1, and then upload this modified log to warcraft logs, the SPELL_PERIODIC_DAMAGE looks correct.

This is the unmodified log, broken negative damage:
https://www.warcraftlogs.com/reports/Rh6mgax3nDXCHwpQ#fight=last

This is the modified log, damage looks correct:
https://www.warcraftlogs.com/reports/xkAtF9HZWp1v4RdB#fight=last


This is the quick&dirty HTML page with javascript code that I used to modify the log: https://pastebin.com/k7SrLyWQ
If you save it as HTML and open it in a browser you can paste a combat log of a fight into the upper textarea (max. 1 fight or it may be too big and crashes the browser) and it will produce the fixed log in the lower textarea.

I didn't find any documentation on combat logging so I have no clue what this number before the 32 is, but it seems wrong.

Relationships

related to 0006445 closed Странное нанесение урона дотами 

Activities

Sulphos

2020-03-06 01:27

reporter  

warcraftlogs broken damage meter.png (120,461 bytes)
imonar_agony.png (513,768 bytes)

Sulphos

2020-03-06 01:30

reporter   ~0025260

And on a note: I found an old Legion log from the official server on my computer, and uploaded it to warcraftlogs.com, and it worked just fine, the damage was correct, no negative numbers. This proves that the issue does not exist because something in BfA might have changed.

Sulphos

2020-03-06 11:04

reporter   ~0025273

I've just been told that in addition "melee" auto attack damage isn't logged at all, and indeed it doesn't appear in the log or report.

Sulphos

2020-03-06 15:33

reporter   ~0025290

Another update on autoattacks. It seems that melee autoattacks appear as SWING_DAMAGE. Below is comparison between a SWING_DAMAGE log entry from ArgusWoW and from Legion official.

Arguswow swing dmg log:
3/6 15:02:28.869 SWING_DAMAGE,Player-3-000149A6 ,"Sulphos-argusx100" ,0x511,0x0,Creature-0-3-1220-0-106920-0008D68D7A ,"Feathered Prowler",0x10a48,0x0,Player-3-000149A6,0000000000000000,5944320,5944320,0,68554,0,1100000,1100000,0,545.27,5758.00,962,23938,-1,1,0,0,0,1,nil,nil

Legion official client swing dmg log
3/7 19:21:22.679 SWING_DAMAGE,Player-1121-067F26D8,"Sulphur-KultderVerdammten",0x511,0x0,Creature-0-3892-1501-22224-98677-0000BEF8DF,"Rabenspinnling" ,0x10a48,0x0,0000000000000000 ,0000000000000000,0 ,0 ,0,0 ,-1,0 ,0 ,0,0.00 ,0.00 ,0 ,15442,-1,1,0,0,0,nil,nil,nil

Notice how the columns differ. I've edited my javascript and they now also make the autoattacks show on warcraftlogs (new script url) https://pastebin.com/aU5iMMJL

Sun of a Bit

2020-03-12 17:31

reporter   ~0025719

Fixed. Please, check this after next update. Thx for the report.

Sulphos

2020-03-20 14:44

reporter   ~0026215

I confirm that SPELL_PERIODIC_DAMAGE looks correct now on warcraftlogs!

However, melee damage still doesn't appear. I had posted the melee damage issue in the comments (2020-03-06 17:33.)

This is the newest report where dots are fixed but melee isn't: https://www.warcraftlogs.com/reports/JLmTdtRYMC2FNr9k#fight=12

Sun of a Bit

2020-04-03 10:45

reporter   ~0027100

So, think I found the problem. Please, can you check how it will be work after next update and leave feedback here?

Sulphos

2020-04-03 12:45

reporter   ~0027106

Thanks for the response, yes i will check!

Sulphos

2020-04-05 00:16

reporter   ~0027251

I confirm that the latest report contains melee damage as well, good job!

Sun of a Bit

2020-04-06 22:26

reporter   ~0027408

Thanks for the report and have a good game.

Issue History

Date Modified Username Field Change
2020-03-06 01:27 Sulphos New Issue
2020-03-06 01:27 Sulphos Status new => assigned
2020-03-06 01:27 Sulphos Assigned To => Mentor
2020-03-06 01:27 Sulphos File Added: warcraftlogs broken damage meter.png
2020-03-06 01:27 Sulphos File Added: imonar_agony.png
2020-03-06 01:30 Sulphos Note Added: 0025260
2020-03-06 10:32 Mentor Assigned To Mentor => deadinside
2020-03-06 11:04 Sulphos Note Added: 0025273
2020-03-06 15:33 Sulphos Note Added: 0025290
2020-03-07 11:23 deadinside Status assigned => acknowledged
2020-03-07 11:29 deadinside Relationship added related to 0006445
2020-03-09 12:31 deadinside Assigned To deadinside => Sun of a Bit
2020-03-09 12:31 deadinside Status acknowledged => confirmed
2020-03-12 17:31 Sun of a Bit Note Added: 0025719
2020-03-12 17:31 Sun of a Bit Status confirmed => resolved
2020-03-20 14:44 Sulphos Status resolved => feedback
2020-03-20 14:44 Sulphos Resolution open => reopened
2020-03-20 14:44 Sulphos Note Added: 0026215
2020-04-01 09:14 Sun of a Bit Status feedback => acknowledged
2020-04-03 10:45 Sun of a Bit Note Added: 0027100
2020-04-03 10:45 Sun of a Bit Status acknowledged => feedback
2020-04-03 12:45 Sulphos Note Added: 0027106
2020-04-03 12:45 Sulphos Status feedback => assigned
2020-04-05 00:16 Sulphos Note Added: 0027251
2020-04-06 22:26 Sun of a Bit Note Added: 0027408
2020-04-06 22:26 Sun of a Bit Status assigned => resolved